Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add gen-ai-card block #51

Merged
merged 9 commits into from
Sep 11, 2024
Merged

feat: add gen-ai-card block #51

merged 9 commits into from
Sep 11, 2024

Conversation

jrrings
Copy link
Contributor

@jrrings jrrings commented Aug 26, 2024

Copy link

aem-code-sync bot commented Aug 26, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link

aem-code-sync bot commented Aug 26, 2024

@codecov-commenter
Copy link

codecov-commenter commented Aug 28, 2024

Codecov Report

Attention: Patch coverage is 93.75000% with 14 lines in your changes missing coverage. Please review.

Project coverage is 39.43%. Comparing base (185b7ee) to head (9648a07).
Report is 13 commits behind head on main.

Files with missing lines Patch % Lines
express/blocks/gen-ai-cards/gen-ai-cards.js 93.72% 14 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #51      +/-   ##
==========================================
+ Coverage   38.76%   39.43%   +0.66%     
==========================================
  Files          45       47       +2     
  Lines        9756    10007     +251     
==========================================
+ Hits         3782     3946     +164     
- Misses       5974     6061      +87     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@vhargrave vhargrave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the buttons here look wrong as does the title which contains the creator's name. There should also be some distance to the block above: https://mwpw-143415--express-milo--adobecom.hlx.page/express/collaborations

also on the homepage the block doesn't look right
image

express/blocks/gen-ai-cards/gen-ai-cards.js Outdated Show resolved Hide resolved
Copy link
Collaborator

@vhargrave vhargrave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jrrings when I enter a prompt to generate an image the category in the URL is ?category=template vs ?category=media on production. It doesn't seem to affect the final image, but can you investigate if we can pass the same query param as prod?

@vhargrave vhargrave merged commit 53a480c into main Sep 11, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants